debug: Enforce programmer selection #2394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaglie
added
topic: code
alessio-perugini
approved these changes
Oct 30, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2394 +/- ##
==========================================
+ Coverage 64.48% 64.51% +0.03%
==========================================
Files 207 207
Lines 19592 19594 +2
==========================================
+ Hits 12633 12641 +8
+ Misses 5867 5863 -4
+ Partials 1092 1090 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
alessio-perugini
approved these changes
Oct 31, 2023
umbynos
approved these changes
Oct 31, 2023
|
@kittaakos I'm cherry-picking this one in the |
cmaglie
added a commit
that referenced
this pull request
Oct 31, 2023
* debug: Enforce programmer selection * Fixed unit tests * Increase code coverage
3 tasks
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Enforce programmer selection to
debug.What is the current behavior?
The
debugcommand allows running without specifying the-Pflag.What is the new behavior?
Does this PR introduce a breaking change, and is titled accordingly?
Other information